general-codereview
General Code Review Skill
A comprehensive code review methodology based on Google's engineering practices. Follow these 5 steps to perform effective and thorough code reviews.
Step 1: Pre-screen
Before diving into the code, perform a quick pre-screening:
Check Size
- Reasonable size: A change list of ~300 lines of code is typically reasonable
- Too large: Larger CLs should be strongly discouraged unless necessary
- Leave a comment asking if the CL can be broken down into smaller, logically complete parts
- Ask for the reason if breaking down is not possible
- Small is OK: Even single-line changes are fine as long as they are logically complete
Verify You're the Right Reviewer
More from xinbenlv/codereview-skills
codereview-architect
Deep codebase context analysis like Greptile. Analyzes blast radius of changes, dependency graphs, and architectural consistency. Use when reviewing changes to core utilities, shared libraries, or database models.
18codereview-correctness
Analyze code for logic bugs, error handling issues, and edge cases. Detects off-by-one errors, null handling, race conditions, and incorrect error paths. Use when reviewing core business logic or complex algorithms.
4codereview-api
Review API contracts, breaking changes, and interface consistency. Analyzes REST/RPC endpoints, event schemas, versioning, and backward compatibility. Use when reviewing public interfaces, API routes, or service contracts.
2codereview-testing
Review test coverage and quality. Analyzes unit tests, integration tests, determinism, and test design. Use when reviewing test files or code that should have tests.
2codereview-style
Review code style, maintainability, and documentation. Checks readability, naming, modularity, abstractions, and documentation accuracy. Use as a final pass on all files.
1codereview-data
Review database operations, migrations, and data persistence. Analyzes query safety, migration rollback, transaction boundaries, and data integrity. Use when reviewing migrations, models, repositories, or database queries.
1