Code Review Process

Step-by-Step Review Workflow

1. Understand Context

• Read the PR description and linked issues
• Understand what problem is being solved and why
• Check if the approach was discussed beforehand (design doc, RFC, issue thread)

2. High-Level Pass

• Look at the file list -- does the scope make sense for the stated goal?
• Check for unrelated changes mixed in (should be separate PRs)
• Review the overall architecture: does the approach fit the codebase patterns?

3. Detailed Review

• Walk through the code in logical order (not file order)
• Start from the entry point and follow the data flow
• For each change, evaluate against the review dimensions (correctness, architecture, naming, tests, errors, security)
• Note findings with severity, location, issue, and suggestion