PR Review

Answer a fixed chain of questions in order, with evidence. Stay read-only unless authorized.

Pin down what you are reviewing

Read repository rules. Identify what is under review — the exact head SHA, or a provided patch or snapshot — and state any mismatch with the live PR. Gather PR/Issue links, +A/-D, files, the production/test split, CI, mergeability, and review state. Never mix versions. Name missing facts; gaps do not block analysis.

What problem does this PR solve, and is it real?

State, in the PR's own terms, what problem it solves and how. Then check the problem is real: seek a report, reproduction, log, or failing check — an Issue is optional, and a new test proves neither demand nor prior failure. Classify the problem demonstrated, plausible but unverified, disproved, or mismatched, and confirm the PR covers the reported scenario rather than a different one.

Is the problem defined correctly, and is this the right solution?

Judge both from first principles: does the change fix the cause at the code that owns it, or patch around it with copied state, another loop, a second source of truth, or a compatibility path? Follow the real production path — the shortest supported route that could prove the fix wrong — and compare old and new behavior where producer meets consumer:

• fixtures do not prove launchers, helpers do not prove callers, and in-process tests do not prove process races;
• supported callers and later use of changed data must survive failure, retry, concurrency, restart, and recovery;
• prefer an existing extension point over a new implementation, wrapper, or state machine.