dsh-code-review
Installation
SKILL.md
Reviewing a DeepSeek-Harness PR
This skill is guidance, not a complete checklist. Verify and fetch the PR's live base and exact head, then run pnpm --silent run change-scope --base <verified-base-ref> --head <verified-head-ref> before reading the diff and enough surrounding code to understand the design. The report identifies paths and dirty layers but does not replace semantic review. Re-establish the base and rerun it after a retarget or merge. Prioritize correctness, lifecycle, security, and broken required behavior over style; a short review with one substantiated blocker is better than a list of nits.
Sources of truth
- AGENTS.md and packages/AGENTS.md: standing repository and package authoring rules.
- docs/defensive-patterns.md: subprocess, callback, async-state, and disposal bug classes.
- docs/AGENTS.md: documentation placement and prose discipline.
- dsh-prose-standard: required coverage and editorial judgment for comments, docs, prompts, and visible strings.
- dsh-ci-test-reliability: isolation and regression-proof rules for resource-owning, asynchronous, or flaky tests and fixtures.
- docs/testing.md and the quality-gates Agent Note: required test tiers and gates.
- Agent Notes: design rationale. Treat disagreement with an Agent Note as a design discussion, not an automatic veto.
- For bilingual changes, read translation-rules.md and terminology.md; the extended translation skill is outside automatic review and runs only on explicit user invocation.