reviewing-ffmpeg-skill-changes
Reviewing ffmpeg-skill Changes
This repository has an unusual failure mode, and a review that misses it looks
thorough while catching nothing. The product is a JSON result document that an
agent reads instead of watching the video. A change can be correct at the FFmpeg
layer, correct at the Python layer, and still ship a lie at the layer that
matters: status: "completed" next to a non-zero exit, verified: true for
something the tool never measured, a cut described as lossless when the keyframe
snap moved it 1.24 s. The 0.9.1/0.10.0 "honesty fix" (cut.py's mode /
keyframe_snapped / duration_delta_seconds, check.py's reason, render.py's
check-stage exit code) exists because three such claims shipped and were caught
after the fact. Review the claim, not just the code.
The second failure mode is re-reporting decisions. Three review rounds on
2026-09-12 re-reported entries in docs/design-decisions.md, which is why that
file exists.