starknet-agentic-skills

No clear embedded malware behavior is evident in this fragment (no obfuscated payloads, no eval/dynamic execution, and no direct exfiltration mechanisms). The dominant security concern is high-impact operational/supply-chain risk: it generates and persists private keys to state.json, passes sensitive secrets into spawned subprocesses (including an npm dev server in a configurable directory), and launches an MCP dist entrypoint that can perform privileged on-chain actions. If any of those external/local components are tampered with or misconfigured, secret exposure and unintended transactions become plausible. Review and harden SISNA_DIR/dist integrity, minimize env passthrough, and avoid storing unredacted private keys on disk or use encrypted/managed secret storage.

BENIGN. The skill’s capabilities, credentials, and network flows are consistent with a Starknet confidential-payments skill, and the install path uses standard public npm packages rather than opaque binaries or proxy services. The main risk is operational: it enables autonomous blockchain financial actions using sensitive private keys, so overall security risk is medium-high even without signs of malware.

The scanner report flags multiple high-risk upgradeability and administration anti-patterns across several Cairo/Starknet repositories (immediate upgrades without timelocks, class-hash upgrades lacking nonzero guards, critical-address initialization without guards, irrevocable admin assignments, and unguarded access-control mutations). These are architectural and governance risks that could enable code replacement or admin takeover if an admin key is compromised or a malicious actor obtains privileged access. There is no evidence in this artifact of classical malware behaviors (exfiltration, backdoors, network connections, hard-coded secrets, or obfuscation of payloads). Action: perform targeted manual review of the listed files/lines, verify on-chain governance (timelocks/multisig), add or enforce nonzero guards, and remediate irrevocable admin patterns where unsuitable. Treat flagged items as high-priority security review candidates rather than confirmed compromise.

The code is a test runner intended for E2E validation of a spending policy system. It does not appear to implement malicious functionality, but it includes a notable risk: it uses eval to execute dynamically constructed commands from test definitions, which could lead to command injection if inputs are controlled by an attacker. It also prints sensitive-looking inputs (account, session key) to stdout, and stores test outputs in a world-writable /tmp file, which could lead to information leakage in shared environments. Overall, the script is not inherently malicious but has moderate security risk due to dynamic code execution and exposure of sensitive data in logs/outputs. Recommend replacing eval with safer command construction, explicit input validation, and redaction/logging controls for sensitive data.

The provided artifact is a static analysis report summarizing security issues across multiple Cairo smart-contract repositories. It contains no executable or obfuscated malware. The findings, however, reveal numerous high-risk smart-contract design and governance issues (immediate upgrades without timelocks, critical addresses initialized without nonzero guards, irrevocable admin roles, and other logic flaws) that could enable privileged actors to perform malicious on-chain actions or lead to accidental critical failures. I recommend immediate code review and remediation of the flagged contracts before deployment. No direct evidence of embedded malware in the scanned packages is present in this report.

This scan summary does not show explicit malicious code (no network exfiltration, hard-coded credentials or obfuscated payloads in the artifact). However, it highlights systemic, high-risk smart-contract anti-patterns across multiple Starknet/Cairo projects: unguarded critical-address initialization, immediate upgrades without timelocks or nonzero guards, and mutable access-control entrypoints. These design issues materially increase the risk of administrative takeover, immediate malicious upgrades, or denial-of-service. Manual code review of the flagged files (start with redeem_request.cairo and vault/upgrade/initializer functions), verification of deployment-time governance controls, and remediation (nonzero guards, timelocks/multisig gating, strict access checks, CEI compliance) are strongly recommended before trusting or depending on these packages.

The provided artifact is a static scan report listing multiple serious smart-contract security issues across several Cairo/StarkNet repositories. The issues (immediate upgrades without timelock, non-guarded critical address initialization, irrevocable admins, fees recipient set to zero, CEI violation) indicate high-risk patterns that could enable privileged actors to upgrade contracts to malicious versions, seize funds, or cause DoS. This report is not executable code and does not itself show active malware, but it flags misconfigurations and dangerous upgrade/privilege patterns that should be treated as significant security vulnerabilities and remediated before deployment.

This fragment functions as a governance/security posture diff rather than executable code. Removals of critical upgrade-related classes suggest remediation, while additions introduce governance-risk signals that warrant review (IRREVOCABLE_ADMIN, UPGRADE_CLASS_HASH_WITHOUT_NONZERO_GUARD). No evidence of malware, hidden payloads, or data exfiltration is present in this data artifact. Recommended next steps: audit added governance-risk items, verify proper access-control and upgrade authorization configurations, and ensure consistent remediation across repositories.

The scan identifies systematic high-impact governance and upgradeability risks across multiple Starknet/Cairo projects: immediate upgradeability without timelocks, missing non-zero guards in initialization/class-hash setters, and potentially irrevocable admin roles. These issues increase the likelihood of administrative takeover or malicious upgrades if deployed. The artifact is not malware, but the findings represent real on-chain security risks requiring manual verification and remediation (add timelocks/multisig/governance, validation checks, revocation paths). Prioritize review of the flagged files and functions before trusting deployed instances.

Insufficient input to perform a structured adversarial assessment. No findings generated.

This is a valid high-severity access-control finding: session-key execution path forwards untrusted selector/calldata into a syscall that can target the contract itself, enabling invocation of privileged selectors and privilege escalation. Immediate remediation: prevent session-key initiated self-calls (assert call.to != self_addr) and implement an explicit denylist of privileged selectors for session-key flows, plus tests to prevent regression. Confirm that the reported 'fixed' status corresponds to code changes and remove stale vulnerable artifacts from records.

The immediate-upgrade-without-timelock pattern is a high-risk anti-pattern for upgradeable contracts. When an upgrade entrypoint directly calls the class-replacement syscall without recording a pending upgrade or enforcing a minimum delay, it enables instantaneous, irreversible changes by any holder of the privileged key. For production systems that custody third-party assets or rely on distributed governance, this pattern should be remediated by adding scheduled upgrade states, an enforced timelock, cancellation/veto paths, and stronger authorization (multisig/governance). If immediate upgrades are chosen intentionally, that operational decision must be documented and limited to controlled/private deployments.

This is a valid CEI / reentrancy risk pattern: calling ERC‑1155 safe_transfer_from before committing critical state updates and without a reentrancy guard can allow attacker‑controlled recipient callbacks to re‑enter and cause double‑processing or theft. Action: reorder effects before interactions or apply a strong reentrancy guard encompassing the external call; if exceptions exist (trusted recipient or global lock), document and prove them. Validate via tests using a malicious receiver contract.

The documentation describes a high-severity supply-chain/security issue: a test-only fast path that bypasses signature, median, and deviation validations and writes primary prices directly from submitted compacted arrays. If that code path is present and reachable in production, it enables authoritative price manipulation with critical impact (funds theft, forced liquidations). The fragment is descriptive rather than executable; confirm by inspecting the referenced implementation and build/deployment configuration. Mitigation requires removing or gating test paths, enforcing fail-closed validation behavior, and adding tests and CI checks.

The fragment contains a high-severity security logic issue: it forwards attacker-controlled Call entries directly to a privileged system contract call without validating target addresses or selectors. In a session-key or delegated execution context this permits self-calls and invocation of privileged selectors, enabling privilege escalation, unauthorized state modification, and reentrancy risks. The issue appears to be insecure implementation rather than explicit malware, and should be remediated by adding self-call and selector denylist checks, stricter session key restrictions, and safer error handling.