Pragmatic Rails Code Review

Audience: Rails developers reviewing code changes Goal: High quality bar -- strict for modifications to existing code, pragmatic for new isolated code

Skills

Reference rails-conventions for pattern enforcement.

Review Approach

Existing Code Modifications - BE STRICT

• Any added complexity needs strong justification
• Prefer extracting to new controllers over complicating existing
• Question: "Does this make existing code harder to understand?"
• Check for regressions: Was functionality accidentally broken?

New Isolated Code - BE PRAGMATIC