golang-review
Installation
SKILL.md
Review one axis: whether a Go diff follows RULES.md and applicable language contracts. Catalog rules carry aggregate support; version findings cite /golang official contracts, not taste.
Run standalone or inline as the golang hat in /review. Reviewer lanes still require explicit delegation or /swarm.
Exclude
- Anything target
golangci-lintconfig already enforces. - Generic style without catalog/version-contract backing.
- Frontend, vendored, and generated
*.pb.go,*_pb.go,*.connect.go,@generated/DO NOT EDIT. - Catalog debate; submit feedback rather than invert a rule.
Procedure
- Scope: diff fixed point to HEAD. Inspect Go/proto plus
go.mod/go.workwhen toolchain may change. Read.golangci.yml; exclude enabled lint rules. - Classify: proto/API, public SDK/library, handlers, Temporal, controllers, tests, config/rollout, tenant security, concurrency/lifecycle.
- Load: matching RULES.md and
/golangdomain files: PROTO-API, CONCURRENCY, ERRORS, TESTING, TEMPORAL, SECURITY, ROLLOUT, STRUCTURE, CONTROLLERS. For Go 1.27 generic methods, compatibility, or leak profiling, load GO-1.27.md. Apply in-scope S/A rules, clear B violations, and only plain C/D violations; gate release contracts by module version/surface. - Check tensions: positive bool versus fail-closed, enum subset, keepalive, filters. Context decides.
- Report: rule/contract id,
file:line, behavior, required change, priority. Hat limit 400 words; standalone stays concise and sourced.