code-review
Code Review
Review one exact change and give separate verdicts for Correctness and Maintainability. This is read-only: do not edit files, add tests, apply fixes, commit, push, post comments, or resolve threads.
1. Pin the change
Review the pull request, branch, commit range, or working changes the user names. If none is named, review the current branch against the default branch plus uncommitted changes. Record the base and head commits and the merge base, and review git diff <merge-base>..<head> with its commit list. For working changes, include staged, unstaged, and relevant untracked files.
A finding must be caused or made worse by this change. Code outside the diff can be evidence, but a problem that already existed is not a finding. A pre-existing problem in code the change touches directly may be listed as a follow-up; it does not affect the verdict.
2. Gather the requirements
Requirements come from these sources, highest priority first:
- the user's latest decisions in the conversation
- a named specification, or the same-repository issue the change closes
- the pull-request description
- commit messages, and intent inferred from the code