Code Review

A structured, critical read of a diff. Either approve, or send it back with feedback specific enough to act on.

When to Use

Reviewing someone's PR, or self-reviewing a diff before requesting review.

Steps

1. Read the intent — PR description, ticket. Know what the diff should do.
2. Read the diff top to bottom for correctness against that intent.
3. Second pass: edge cases, error handling, concurrency, security.
4. Third pass: tests — do they actually cover the change and its boundaries?
5. Note conventions, naming, readability — lower priority, still note.

Checklist