Reviewing Code

Purpose

Review code changes from a senior engineer's perspective. Prioritize issues that affect correctness, maintainability, security, performance, testability, and production stability.

Do not focus only on surface style or formatting unless the user explicitly asks for that.

Review Workflow

1. Understand the intended change.

   • Infer the intended behavior from the user request, diff, issue, PR/MR description, tests, and surrounding code.
   • If the intent is unclear, state your reasonable assumption.
   • Clearly separate confirmed problems, inferred risks, and things you cannot verify.

2. Check correctness first.

   • Look for logic errors, missing branches, boundary mistakes, off-by-one errors, state pollution, error-handling gaps, and unintended side effects.
   • Check whether the code handles empty inputs, single items, very large inputs, null, undefined, NaN, missing fields, and malformed data when relevant.
   • Verify changed interfaces remain compatible with existing callers.