Code Review

A change is reviewed by someone who did not write it, in two stages: first "does it do exactly what was asked", then "is it built well". The author then explains the change to the user in plain language and discloses everything that was not asked for. The author's confidence is not evidence; a fresh reviewer reading the diff is.

The Prime Directive

NO CHANGE LANDS UNTIL A FRESH REVIEWER HAS PASSED IT AND THE USER HAS SEEN WHAT CHANGED

No exceptions. No workarounds. No shortcuts.

When to Use

Required:

• After every task in a plan, before the next task starts.
• After a feature or a bug fix, before it is committed to a shared branch or merged.
• Before a pull request is opened or marked ready.
• When the user asks for a review of a diff, a branch or a pull request.