clean-code-review
Installation
SKILL.md
Clean Code Review
Scanner path: commands below assume
tools/cc-scan.py/tools/arch-scan.pyare in the repo. If they are not, the same scanners may be onPATHascc-scan/arch-scan(identical flags) — seeINSTALL.md§1b. If neither exists, ask for the report instead of guessing numbers.
Sibling of clean-code. The goal: find the 3 things worth fixing in 30 minutes,
not write 300 comments about style. A review that cannot be prioritised is noise that
the author will negotiate away one line at a time.
0. Severity vocabulary (use these words only)
| Level | Meaning | Effect on merge |
|---|---|---|
| blocker | wrong, lossy, unsafe, or violates an accepted decision (ADR, layer rule, security) | must be fixed here |
| should | correct but expensive to live with: unreadable name, 6 params, no test on the error branch | fix here, or open a ticket the author owns |
| nit | preference-level, no measurable cost | optional; say "take it or leave it" |
| question | you do not understand the intent | the author answers; not a change request |
| praise | something worth copying by the rest of the team | always specific, never generic |