work-wrap-up
Work wrap-up
Take the current branch from "code written" to "staged and ready for the user to commit". Each step ends at a gate; the user decides what gets fixed, what gets committed, and what gets opened as a PR.
Steps
-
Collect the change. Read the branch diff against the merge base with the default branch, plus uncommitted changes:
git diff $(git merge-base HEAD origin/development)andgit status --short. Take the issue number from the branch name (jd-<n>) and read the issue withdf-ti <n>. When an open PR exists for the branch, also read its review comments withdf-tpr <pr>. Done when you hold the changed file list, every ask from the issue, and every unresolved review comment. -
Spec check. Map every ask from step 1 to the change that satisfies it. Report each one as met, partial, or missing, with the file and line. Done when no ask is left unmapped. Stop and ask before going on when anything is partial or missing.
-
Code review. Invoke the
code-reviewskill with the merge base from step 1 as the fixed point. Present its findings numbered, then let the user answer each one (fix, explain more, or leave). Apply exactly the fixes the user accepts. Done when every finding has the user's answer and every accepted fix is applied. -
The loop. Run the loop the repo's
AGENTS.mdnames (mise run blcin the frontend) until it is green. When it is red on a file this branch does not touch, follow thatAGENTS.md's instructions for checkingdevelopmentand running the remaining checks on their own. Done when the loop is green, or red only on linesdevelopmentshares, with the evidence shown. -
Browser test. When the change is user-facing, log in with
mise run pw-loginfrom the frontend worktree, seed what the test needs with theseed:*tasks, and exercise every screen the diff touches. Then exercise the neighbouring features those screens share code with (for a composer change: save, publish, schedule, duplicate). Record each flow and its result. Close the playwright session and stop only the servers you started. Done when every touched screen and its neighbours have a recorded result, or the change is not user-facing and you say why. -
Manual steps. Print numbered steps a person can follow to verify the change in the UI: the seed command or link they need, each action, and the expected result. Done when every ask from step 2 has a step that proves it.
-
Stage. Stage only the files this change touched, by path (
git add <paths>), and list them with one line each on why. Done whengit diff --cached --statshows exactly the change and nothing unrelated.